Skip to content

Make the Path tool support multi-point conversion between smooth/sharp on double-click #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 20, 2025

Conversation

0SlowPoke0
Copy link
Collaborator

@0SlowPoke0 0SlowPoke0 commented Mar 29, 2025

Partly closes #1870

Added feature:

When double-clicking an anchor:

  • Currently this swaps between smooth and sharp, but doesn't work if multiple handles are multi-selected to convert them all to smooth or sharp. If they're of mixed type, the specific one that's double clicked on should be the decider for the rest of them as to which they should all be swapped to.

@Keavon Keavon force-pushed the master branch 4 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
@Keavon Keavon changed the title Path-tool improvements Improve Pen tool behavior when double-clicking anchor points Apr 14, 2025
@Keavon
Copy link
Member

Keavon commented Apr 14, 2025

For the record, I'll copy and paste the point of trickiness that I mentioned in Discord regarding the input conflict in the desired behavior from the first of the two bullet points addressed in this PR:

It might be a little tricky, but can you make it still deselect all others, but if the single click is followed up with a double click, it restores the selection and performs the smooth/sharp swap?

@0SlowPoke0 0SlowPoke0 changed the title Improve Pen tool behavior when double-clicking anchor points Improve Path tool behavior when double-clicking anchor points May 18, 2025
@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review May 19, 2025 09:28
@Keavon Keavon changed the title Improve Path tool behavior when double-clicking anchor points Make the Path tool support multi-point conversion between smooth/sharp on double-click May 20, 2025
@Keavon Keavon merged commit ddb2d74 into GraphiteEditor:master May 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Pen and Path tool improvements
2 participants