Skip to content

Conversation

simonychuang
Copy link
Contributor

@simonychuang simonychuang commented Oct 10, 2025

We redirect the user to the security overview but don't set the active perspective to security which makes the home button take the user back to the general perspective welcome page.

Closes https://github.com/Graylog2/graylog-plugin-enterprise/issues/12032

/nocl

How Has This Been Tested?

Local env

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@simonychuang simonychuang marked this pull request as ready for review October 10, 2025 17:34
@simonychuang simonychuang requested a review from a team October 10, 2025 17:34
Copy link
Contributor

@zeeklop zeeklop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dennisoelkers dennisoelkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two comments, requesting changes just for the second one (fixing the linter hint).

}

redirect(activePerspective.welcomeRoute);
}, [activePerspective, currentUser?.startpage, redirect]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address this linter hint before merge?

} else if (startPage.type === 'stream') {
redirect(Routes.stream_search(startPage.id));
} else if (startPage.type === 'graylog_security_welcome') {
setActivePerspective('security');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixable within this PR, but I want to leave it here for future refactorings: This should not be here, as it couples core and enterprise/security. Instead, we should make this pluggable, so any plugin can register handlers for the types of start pages they are maintaining.

@simonychuang simonychuang marked this pull request as draft October 16, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants