Skip to content

Conversation

dennisoelkers
Copy link
Member

Description

Motivation and Context

This is a follow-up to #23909. When using alternative timestamp fields, we are disabling the zoom handler, as it changes the time range. This works reliably only if the chart is based on the timestamp field as well.

/nocl Fixing unreleased change.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the described problem and zooming into the chart no longer changes the time range.

Some thoughts:

  1. With this approach it is still possible to zoom into the chart, in 6.3 we disabled the zoom in this case completely. I like having the option to always zoom into a timeline chart, but it might be confusing for users, why it has different side effects, depending on the selected field.

  2. When you increase the time range via the plotly controls (for a non timerange timeline), we do not fetch the related results, although there are some.
    Image

@dennisoelkers
Copy link
Member Author

@linuspahl: Fixed that!

Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some failing tests, but the recent changes work well.

@dennisoelkers dennisoelkers force-pushed the fix/disable-zoom-for-non-timestamp-charts branch from 663c31c to b00e698 Compare October 17, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants