Create provider fo output-type frequency#23940
Merged
fpetersen-gl merged 22 commits intomasterfrom Nov 6, 2025
Merged
Conversation
…implifies the code in each supplier a bit.
…ature/outputs_metrics
# Conflicts: # graylog2-server/src/main/java/org/graylog2/telemetry/TelemetryModule.java
…o have it centrally accessible.
garybot2
pushed a commit
that referenced
this pull request
Dec 1, 2025
* Initial version of OutputsMetricsSupplier * Added test * Added license-header to test * Added cl * Simplify code a bit * Filter out empty TelemetryEvents centrally to not report them. That simplifies the code in each supplier a bit. * Add license-header * Adjust test * Formatting the outputs-class names * Move method for formatting all keys of the map to the TypeFormatter to have it centrally accessible. * Move OutputsMetricsSupplier to telemetry-package * Add outputs package to TypeFormatter --------- Co-authored-by: Ismail Belkacim <[email protected]> (cherry picked from commit 525ed23)
9 tasks
garybot2
pushed a commit
that referenced
this pull request
Dec 1, 2025
* Initial version of OutputsMetricsSupplier * Added test * Added license-header to test * Added cl * Simplify code a bit * Filter out empty TelemetryEvents centrally to not report them. That simplifies the code in each supplier a bit. * Add license-header * Adjust test * Formatting the outputs-class names * Move method for formatting all keys of the map to the TypeFormatter to have it centrally accessible. * Move OutputsMetricsSupplier to telemetry-package * Add outputs package to TypeFormatter --------- Co-authored-by: Ismail Belkacim <[email protected]> (cherry picked from commit 525ed23)
9 tasks
garybot2
pushed a commit
that referenced
this pull request
Dec 1, 2025
* Initial version of OutputsMetricsSupplier * Added test * Added license-header to test * Added cl * Simplify code a bit * Filter out empty TelemetryEvents centrally to not report them. That simplifies the code in each supplier a bit. * Add license-header * Adjust test * Formatting the outputs-class names * Move method for formatting all keys of the map to the TypeFormatter to have it centrally accessible. * Move OutputsMetricsSupplier to telemetry-package * Add outputs package to TypeFormatter --------- Co-authored-by: Ismail Belkacim <[email protected]> (cherry picked from commit 525ed23)
9 tasks
xd4rker
added a commit
that referenced
this pull request
Dec 1, 2025
* Initial version of OutputsMetricsSupplier * Added test * Added license-header to test * Added cl * Simplify code a bit * Filter out empty TelemetryEvents centrally to not report them. That simplifies the code in each supplier a bit. * Add license-header * Adjust test * Formatting the outputs-class names * Move method for formatting all keys of the map to the TypeFormatter to have it centrally accessible. * Move OutputsMetricsSupplier to telemetry-package * Add outputs package to TypeFormatter --------- (cherry picked from commit 525ed23) Co-authored-by: Florian Petersen <[email protected]> Co-authored-by: Ismail Belkacim <[email protected]>
xd4rker
added a commit
that referenced
this pull request
Dec 2, 2025
* Initial version of OutputsMetricsSupplier * Added test * Added license-header to test * Added cl * Simplify code a bit * Filter out empty TelemetryEvents centrally to not report them. That simplifies the code in each supplier a bit. * Add license-header * Adjust test * Formatting the outputs-class names * Move method for formatting all keys of the map to the TypeFormatter to have it centrally accessible. * Move OutputsMetricsSupplier to telemetry-package * Add outputs package to TypeFormatter --------- (cherry picked from commit 525ed23) Co-authored-by: Florian Petersen <[email protected]> Co-authored-by: Ismail Belkacim <[email protected]>
xd4rker
added a commit
that referenced
this pull request
Dec 2, 2025
* Initial version of OutputsMetricsSupplier * Added test * Added license-header to test * Added cl * Simplify code a bit * Filter out empty TelemetryEvents centrally to not report them. That simplifies the code in each supplier a bit. * Add license-header * Adjust test * Formatting the outputs-class names * Move method for formatting all keys of the map to the TypeFormatter to have it centrally accessible. * Move OutputsMetricsSupplier to telemetry-package * Add outputs package to TypeFormatter --------- (cherry picked from commit 525ed23) Co-authored-by: Florian Petersen <[email protected]> Co-authored-by: Ismail Belkacim <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep track of the output-types' frequency, in case telemetry is enabled. So we count how many outputs of each type are used by the system and report that.
Description
This PR simply calls an already existing method in the
OutputService(which I made a bit more readable), converts it into aTelemetryEventand returns that to theTelemetrySubmissionPeriodical.Fixes Graylog2/graylog-plugin-enterprise#12203
Motivation and Context
How Has This Been Tested?
There's a test and the code also ran on a local instance, the metric does end up in posthog.
Types of changes
Checklist: