chore: Bump grmtools version #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the current unused tokens in the grammar file, this requires turning "warnings are errors" (the default) off.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 98.99% 98.99%
=======================================
Files 14 14
Lines 6272 6272
=======================================
Hits 6209 6209
Misses 63 63 ☔ View full report in Codecov by Sentry. |
yuanbohan
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of grmtools promql-parser is using to 0.13.*. This has breaking changes in the API (see https://github.com/softdevteam/grmtools/blob/master/CHANGES.md) and also turns "unused tokens in the grammar" into errors. The first commit is the "minimal" update, but does leave cargo churning out error warnings. The second commit adds grmtools'
%expect-unusedlines to silence these warnings. I appreciate that this might not be what you want in a generated file, but I thought it would be useful to show what is necessary in this file to have a smooth experience.