MIMD-13-Label-improvements-and-helper-text #38
Conversation
elwills
left a comment
elwills
left a comment
There was a problem hiding this comment.
After peeping the model, I realize that Station actually is the AssetKey, so what's missing is actually Meter.Name. This isn't currently part of the model, so that would need to be added in order to have both. I think for now, we could just drop this requirement.
Source/Applications/MiMD/wwwroot/Scripts/TSX/MiMD/Configuration/ConfigurationByMeter.tsx
Outdated
Show resolved
Hide resolved
| ]} /> | ||
| <ConfigRuleValueTableField Record={currentRule} Edit={false} updateRule={(rule) => setCurrentRule(rule)} Label={'Value'} /> | ||
| <Select<MiMD.IConfigRules> Record={currentRule} Field={'AdditionalFieldID'} Disabled={false} Label={'Additional Field'} Setter={(rule) => setCurrentRule(rule)} | ||
| <ConfigRuleValueTableField Record={currentRule} Edit={false} Help={'See the Help :question_mark: at the bottom of this window for dynamic expression examples.'} updateRule={(rule) => setCurrentRule(rule)} Label={'Value'}/> |
There was a problem hiding this comment.
| <ConfigRuleValueTableField Record={currentRule} Edit={false} Help={'See the Help :question_mark: at the bottom of this window for dynamic expression examples.'} updateRule={(rule) => setCurrentRule(rule)} Label={'Value'}/> | |
| <ConfigRuleValueTableField Record={currentRule} Edit={false} Help={'See the Help ? at the bottom of this window for dynamic expression examples.'} updateRule={(rule) => setCurrentRule(rule)} Label={'Value'}/> |
I think this needs a reword in general. Doesn't help have onclick for more information @prestoncraw or am I misremembering that?
There was a problem hiding this comment.
So help doesnt have an onClick but Help does accept either a string or JSX.Element so you could pass a JSX.Element that has an onClick for Help.
There was a problem hiding this comment.
Ah, that's right. Could we do that here with something that says "click to learn more" and get rid of the "?" button?
There was a problem hiding this comment.
Yeah, I think that would be cleaner
There was a problem hiding this comment.
Passing a JSX.Element into the Help parameter will show the JSX.Element below the Help Icon when the user hovers over it, but when the User tries to click the Element, it disappears, since they are no longer hovering over the Help Icon. At least, that's the behavior I've been getting today while working on it.
There was a problem hiding this comment.
Take a look at how we do this in openHistorian, its the same idea as Gabriel is proposing minus all the HelpTree stuff.
No description provided.