Trying to address GHI 808 #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhysLean/QuantumMechanics/OneDimension/HarmonicOscillator/Examples.lean
Outdated
Show resolved
Hide resolved
Member
|
Also I think we should move this file to: Rather then |
Contributor
Author
|
Hi @jstoobysmith |
| ``` | ||
| -/ | ||
|
|
||
| namespace HarmonicOscillatorExamples |
Member
There was a problem hiding this comment.
One last thing. Can we split this name space up into:
namespace QuantumMechanics
namespace HarmonicOscillator
namespace Examples
otherwise this looks good to me!
Contributor
Author
There was a problem hiding this comment.
Sounds good, just submitted a commit with this fix
…mples.lean fixing namespaces
jstoobysmith
approved these changes
Nov 16, 2025
Member
jstoobysmith
left a comment
jstoobysmith
left a comment
There was a problem hiding this comment.
This now all looks all good to me! Many thanks for this. I'll merge it either later today or tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressubf #808