Add Relative Constraints to Calibration #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The relative constraints for the whole system require the detectors to all be translated and rotated together about the center of the system. This includes a fairly thorough test. It won't be that difficult to add relative constraints for groups too, but that should be done in a separate branch. Signed-off-by: Patrick Avery <[email protected]>
This is what the old tilt *actually* is... Signed-off-by: Patrick Avery <[email protected]>
I'm not sure if this will get used, but let's add it for consistency. It actually makes some changes elsewhere easier. Signed-off-by: Patrick Avery <[email protected]>
|
Hello @psavery! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-15 21:55:16 UTC |
psavery
force-pushed
the
relative-constraints
branch
3 times, most recently
from
5d651b3 to
b8bdd47
Compare
The classes keep track of the current values of the relative parameters (before they were modified by lmfit). This is necessary for modifying all detectors by the diff of the change. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
relative-constraints
branch
from
b8bdd47 to
ad7f741
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 38.78% 39.11% +0.33%
==========================================
Files 134 135 +1
Lines 21988 22168 +180
==========================================
+ Hits 8527 8670 +143
- Misses 13461 13498 +37 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds system relative constraints, where the entire detector system can be tilted/translated.
The center of rotation for the tilt is always about the mean center of the detectors.
This is an ideal setup if many subpanels are present, but their relative positions and tilts should remain fixed, while the entire system is allowed to calibrate.