Fix pinhole offset corrections #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TARDIS should be same now. No special treatment of PXRDIP data needed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #727 +/- ##
==========================================
- Coverage 39.11% 39.10% -0.01%
==========================================
Files 135 135
Lines 22168 22171 +3
==========================================
Hits 8670 8670
- Misses 13498 13501 +3 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@psavery This should solve our problem of having different eta angles for |
psavery
reviewed
Nov 13, 2024
use `np.isclose` instead of `==` Co-authored-by: Patrick Avery <[email protected]>
psavery
reviewed
Nov 13, 2024
psavery
approved these changes
Nov 13, 2024
Collaborator
psavery
left a comment
psavery
left a comment
There was a problem hiding this comment.
I had one last change requested, but I'll go ahead and approve too.
Co-authored-by: Patrick Avery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix pinhole corrections for edge cases. All variables for PXRDIP and TARDIS should be same now. No special treatment of PXRDIP data needed.