Take omega edges from imageseries omegas #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #817 +/- ##
=======================================
Coverage 48.61% 48.62%
=======================================
Files 143 143
Lines 22825 22825
=======================================
+ Hits 11097 11099 +2
+ Misses 11728 11726 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This fixes an issue introduced in #786. That only worked if the omega period was 0 to 360 degrees. However, it failed to work for any other case, and likely caused bad results. This takes care of the issue, however. Fixes: #811 Signed-off-by: Patrick Avery <[email protected]>
psavery
changed the title
Collaborator
Author
|
Merging, as this is urgent... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in #786. That only worked if the omega period was 0 to 360 degrees. However, it failed to work for any other case, and likely caused bad results.
This takes care of the issue, however.
Fixes: #811