Avoid using csr_sample_values
#821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scipy is moving away from using csr_matrix and using csr_array for everything, similarly to how numpy moved away from `np.matrix` and started using `np.ndarray` for everything. We ought to use `csr_array` instead. Signed-off-by: Patrick Avery <[email protected]>
Instead we should ravel and reshape the `csr_array`. See discussion [here](scipy/scipy#23211). Signed-off-by: Patrick Avery <[email protected]>
bnmajor
approved these changes
Jul 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 48.65% 48.63% -0.02%
==========================================
Files 143 143
Lines 22919 22911 -8
==========================================
- Hits 11151 11143 -8
Misses 11768 11768 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we should ravel and reshape the
csr_array.See discussion here.