Remove tth_distortion properties from calibrator #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make sense for an instrument calibrator to have tth_distortion properties, because each modal calibrator inside might have a different `tth_distortion` dict. To avoid confusion, just remove this property. Signed-off-by: Patrick Avery <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #828 +/- ##
==========================================
- Coverage 49.24% 49.24% -0.01%
==========================================
Files 144 144
Lines 23286 23279 -7
==========================================
- Hits 11467 11463 -4
+ Misses 11819 11816 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense for an instrument calibrator to have tth_distortion properties, because each modal calibrator inside might have a different
tth_distortiondict.To avoid confusion, just remove this property.