Use np.load() within a context manager #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NpzFile class does not automatically close the file. This can lead to issues especially when multiple applications are reading/writing to the same file. We noticed that if the GUI had an npz file open, and then in Python scripts we overwrote the npz file, that it would not overwrite correctly. Using the context manager ensures that the file gets closed automatically when we are done with it, and should hopefully resolve this issue. Signed-off-by: Patrick Avery <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #832 +/- ##
=======================================
Coverage 49.26% 49.26%
=======================================
Files 143 143
Lines 23107 23109 +2
=======================================
+ Hits 11383 11385 +2
Misses 11724 11724 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bnmajor
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NpzFile class does not automatically close the file. This can lead to issues especially when multiple applications are reading/writing to the same file.
We noticed that if the GUI had an npz file open, and then in Python scripts we overwrote the npz file, that it would not overwrite correctly (the write would appear successful, but the file would remain unchanged).
Using the context manager ensures that the file gets closed automatically when we are done with it, and should hopefully resolve this issue.