Refactor WPPF classes to use a base class #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identical functions are to be used in the base class. This eliminates a significant amount of code (at least 1000 lines). This also fixes the degree of crystallinity calculation of Rietveld to match that of LeBail (which was fixed recently). Signed-off-by: Patrick Avery <[email protected]>
This can be used by Rietveld also Signed-off-by: Patrick Avery <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #838 +/- ##
==========================================
- Coverage 49.27% 48.87% -0.40%
==========================================
Files 143 143
Lines 23120 22182 -938
==========================================
- Hits 11392 10842 -550
+ Misses 11728 11340 -388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This eliminates a lot of duplicate code. Signed-off-by: Patrick Avery <[email protected]>
Signed-off-by: Patrick Avery <[email protected]>
The Rietveld material inherits from the LeBail material, since it needs all of the same calculations as LeBail, plus a little more. Signed-off-by: Patrick Avery <[email protected]>
saransh13
approved these changes
Sep 11, 2025
Member
saransh13
left a comment
saransh13
left a comment
There was a problem hiding this comment.
I have looked at the code and also tested it for many different configurations. Everything seems to be working as expected, so approving the changes.
Collaborator
Author
|
1630 fewer lines of code now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical functions are to be used in the base class.
This eliminates a significant amount of code (at least 1000 lines).
This also fixes the degree of crystallinity calculation of Rietveld to match that of LeBail (which was fixed recently).