Ensure areas are positive in auto powder picking #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The areas can be negative if the beam vector is in the opposite direction from which HEXRD would normally expect it (HEXRD normally expects a negative Z beam vector). The powder picking code was assuming the areas are positive. Take the absolute value to ensure that is the case. This fixes automatic point picking for positive beam vectors. Signed-off-by: Patrick Avery <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #841 +/- ##
=======================================
Coverage 48.95% 48.95%
=======================================
Files 143 143
Lines 22071 22072 +1
=======================================
+ Hits 10805 10806 +1
Misses 11266 11266 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The areas can be negative if the beam vector is in the opposite direction from which HEXRD would normally expect it (HEXRD normally expects a negative Z beam vector).
The powder picking code was assuming the areas are positive. Take the absolute value to ensure that is the case. This fixes automatic point picking for positive beam vectors.