Intensity extraction fixes #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saransh13
force-pushed
the
intensity-extraction-fixes
branch
from
e1b2d8d to
0761298
Compare
…e as the input polar view.
Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
intensity-extraction-fixes
branch
from
f9ad16d to
b33d0e2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
==========================================
+ Coverage 55.96% 56.01% +0.04%
==========================================
Files 143 143
Lines 21963 22010 +47
==========================================
+ Hits 12291 12328 +37
- Misses 9672 9682 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
psavery
force-pushed
the
intensity-extraction-fixes
branch
from
2ec9dd9 to
57d9f3f
Compare
This is mainly for the simulated polar view, because the relative tolerances close to 0 were off by quite a lot. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
intensity-extraction-fixes
branch
from
57d9f3f to
107b232
Compare
Signed-off-by: Patrick Avery <[email protected]>
Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
intensity-extraction-fixes
branch
from
d6b07ad to
70f300f
Compare
Windows is producing slightly different results for the simulated polar view, but it is small enough for a relative tolerance of 1e-2 to work fine. The refined texture parameters come out very slightly different. There are probably just some small nuance differences between Windows and the other operating systems. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
intensity-extraction-fixes
branch
from
70f300f to
0dd5594
Compare
psavery
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor tweaks to the intensity extraction function. The changes speeds up the extraction process and also makes it quite stable. Tested with some NIF and simulated data example.
This is rebased to texture-fixes, so should be merged after #843