Fix issues with multiple texture models #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a few issues with multiple texture models. Now, you can have some materials with texture modeling and some without texture modeling. You also no longer have to refine harmonic coefficients for all texture models (you can disable some). This also sanitizes the material name so that materials may contain a `-` in them without causing errors in lmfit. Signed-off-by: Patrick Avery <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #848 +/- ##
=======================================
Coverage 56.01% 56.01%
=======================================
Files 143 143
Lines 22010 22017 +7
=======================================
+ Hits 12328 12333 +5
- Misses 9682 9684 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
There seems to be an issue with the CI. It seems that the miniconda installer is requiring a newer version of glibc than we have in our docker container. It's unrelated to this PR, so we will merge anyways. But it's something we'll need to fix in the Linux packaging soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with multiple texture models. Now, you can have some materials with texture modeling and some without texture modeling. You also no longer have to refine harmonic coefficients for all texture models (you can disable some).
This also sanitizes the material name so that materials may contain a
-in them without causing errors in lmfit.