Disable non-selected x-ray source pick paths

If "Show picks from all x-ray sources" is not checked, picks for
the non-selected x-ray source are now grayed out and not editable.
This is much better than before, where an error would simply occur
if users tried to edit non-selected x-ray source picks (or worse,
in structureless calibration, the point would be added inadvertently
to the wrong source).

Signed-off-by: Patrick Avery <[email protected]>

Author: psavery

hexrdgui/calibration/calibration_runner.py

@@ -981,8 +981,11 @@ def clear_drawn_picks(self):
 
     def on_edit_picks_clicked(self):
         dialog = self.edit_picks_dialog
+        tree_view = dialog.tree_view
+        model = tree_view.model()
+        model.disabled_paths.clear()
+
         dialog.button_box_visible = True
-        dialog.ui.show()
 
         def on_finished():
             self.dialog.show()
@@ -994,6 +997,24 @@ def on_finished():
         self.draw_picks_on_canvas()
         self.dialog.hide()
 
+        # After the tree view is updated, disable paths that
+        # don't match this XRS.
+        if (
+            HexrdConfig().has_multi_xrs and
+            not self.showing_picks_from_all_xray_sources
+        ):
+            # Disable paths that don't match this XRS
+            for item in model.root_item.child_items:
+                overlay_name = item.data(0)
+                overlay = Overlay.from_name(overlay_name)
+
+                if overlay.xray_source != HexrdConfig().active_beam_name:
+                    model.disabled_paths.append((overlay_name,))
+
+            tree_view.collapse_disabled_paths()
+
+        dialog.ui.show()
+
     def save_picks_to_file(self, selected_file):
         # Reuse the same logic from the HKLPicksTreeViewDialog
         self.edit_picks_dialog.export_picks(selected_file)

hexrdgui/calibration/structureless/runner.py

@@ -499,6 +499,7 @@ def draw_picks_on_canvas(self):
     def on_edit_picks_clicked(self):
         # Convert to polar lines
         data = cart_to_polar_lines(self.calibrator_lines, self.instr)
+        disabled_paths = []
 
         # Now convert to a dictionary for the line labels
         dictionary = {}
@@ -510,6 +511,12 @@ def on_edit_picks_clicked(self):
                 this_xrs[name] = v.tolist()
             ring_indices[xray_source] = ring_idx
 
+            if (
+                not self.showing_picks_from_all_xray_sources and
+                xray_source != HexrdConfig().active_beam_name
+            ):
+                disabled_paths.append((xray_source,))
+
         def new_line_name_generator(path):
             # Get the x-ray source
             xray_source = path[0]
@@ -519,12 +526,14 @@ def new_line_name_generator(path):
         dialog = GenericPicksTreeViewDialog(dictionary, canvas=self.canvas,
                                             parent=self.canvas)
         dialog.tree_view.new_line_name_generator = new_line_name_generator
+        dialog.tree_view.model().disabled_paths = disabled_paths
         dialog.accepted.connect(self.on_edit_picks_accepted)
         dialog.finished.connect(self.on_edit_picks_finished)
         dialog.show()
 
         self.edit_picks_dictionary = dictionary
         self.edit_picks_dialog = dialog
+        dialog.tree_view.collapse_disabled_paths()
 
         self.clear_drawn_picks()
         self.dialog.hide()

hexrdgui/tree_views/base_dict_tree_item_model.py

@@ -22,6 +22,7 @@ def __init__(self, dictionary, parent=None):
         # These can be modified anytime
         self.lists_resizable = True
         self._blacklisted_paths = []
+        self.disabled_paths = []
         self.editable = True
 
         self.config = dictionary
@@ -101,6 +102,12 @@ def flags(self, index):
         flags = super().flags(index)
         item = self.get_item(index)
 
+        if self.has_disabled_paths:
+            path = self.path_to_item(item)
+            if self.is_disabled_path(path):
+                flags = flags & ~Qt.ItemIsEnabled
+                return flags
+
         # Items are selectable if they have no children
         # and none of the data values in the row are `None`.
         is_selectable = all((
@@ -246,6 +253,18 @@ def blacklisted_paths(self, v):
         self._blacklisted_paths = [list(x) for x in v]
         self.rebuild_tree()
 
+    @property
+    def has_disabled_paths(self) -> bool:
+        return bool(self.disabled_paths)
+
+    def is_disabled_path(self, path: list[str] | tuple[str]) -> bool:
+        path = tuple(path)
+        for disabled_path in self.disabled_paths:
+            if path[:len(disabled_path)] == disabled_path:
+                return True
+
+        return False
+
 
 class BaseDictTreeView(QTreeView):
 
@@ -285,6 +304,12 @@ def expand_rows(self, parent=QModelIndex(), rows=None):
                 self.expand(index)
                 self.expand_rows(index)
 
+    def collapse_disabled_paths(self):
+        model = self.model()
+        for path in model.disabled_paths:
+            index = model.create_index(path)
+            self.collapse(index)
+
     @property
     def lists_resizable(self):
         return self.model().lists_resizable

hexrdgui/tree_views/generic_picks_tree_view.py

@@ -411,6 +411,10 @@ def contextMenuEvent(self, event):
         num_selected = len(selected_items)
         is_hand_pickable = self.is_hand_pickable
 
+        if self.model().is_disabled_path(path):
+            # If it is a disabled path, do not create the context menu
+            return
+
         menu = QMenu(self)
 
         # Helper functions

hexrdgui/tree_views/hkl_picks_tree_view.py

@@ -99,6 +99,10 @@ def contextMenuEvent(self, event):
         num_selected = len(selected_items)
         is_hand_pickable = self.is_hand_pickable
 
+        if self.model().is_disabled_path(path):
+            # If it is a disabled path, do not create the context menu
+            return
+
         menu = QMenu(self)
 
         # Helper functions