Add ability to delete grains in some dialogs #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: we need to make sure hexrd's fit-grains will work for discontinuous grain ids (for instance, there are 3 grains, and the user deletes grain id 1, so there are grain ids 0 and 2 left) (see HEXRD/hexrd#453). |
|
@psavery -- here is a proposed interim solution; upon deletion, can we just renumber the remaining grains in the table sequentially in the GUI form? |
This adds the ability to delete grains in the fit grains options dialog (before fit grains is ran), and in the fit grains results dialog (after fit grains is ran). The user may delete grains by right-clicking them in the table and clicking "Delete grain(s)". Note that it is currently set up to not allow the user to delete all grains. Signed-off-by: Patrick Avery <[email protected]>
joelvbernier
approved these changes
Aug 25, 2022
This is a great fix for the fact that hexrd expects the grains to be sequentially numbered. We might be able to skip this in the future if the requirement is removed from hexrd, but this works fine for now. Signed-off-by: Patrick Avery <[email protected]>
|
@joelvbernier The fix seems to be working great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to delete grains in the fit grains options
dialog (before fit grains is ran), and in the fit grains results
dialog (after fit grains is ran).
The user may delete grains by right-clicking them in the table and
clicking "Delete grain(s)". Note that it is currently set up to not
allow the user to delete all grains.