Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help buttons to indexing dialogs #1551

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Add help buttons to indexing dialogs #1551

merged 8 commits into from
Jul 31, 2023

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Jul 27, 2023

The corresponding docs commit hasn't been merged yet. Once it is in, we can merge this one too.

Previously, it would just exit the indexing workflow entirely.
But it is more convenient for users to go back one step and open
the previous dialog, so that they may select different settings
and try again.

Signed-off-by: Patrick Avery <[email protected]>
If the indexing results are rejected after re-running the clustering,
go back to the re-run clustering dialog instead of the eta omega
maps viewer.

Signed-off-by: Patrick Avery <[email protected]>
This is so that on Mac with the default settings on most computers,
you can see the "OK" and "Cancel" buttons.

Otherwise, they are below the screen.

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery requested a review from bnmajor July 31, 2023 03:50
@psavery psavery marked this pull request as ready for review July 31, 2023 04:07
Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@psavery psavery merged commit 901c920 into master Jul 31, 2023
9 checks passed
@psavery psavery deleted the indexing-help-buttons branch July 31, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants