Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure overlay visibility checkbox is updated on state load #1553

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Aug 2, 2023

Fixes #1552

@psavery
Copy link
Collaborator

psavery commented Aug 3, 2023

This looks like it works, but emitting this signal might have other side effects like regenerating overlays (the signal is primarily intended to communicate that overlays need to be regenerated).

Could we instead try adding self.materials_panel.update_gui_from_config() to here?

@bnmajor
Copy link
Collaborator Author

bnmajor commented Aug 3, 2023

Could we instead try adding self.materials_panel.update_gui_from_config() to here?

Sure thing.

@psavery
Copy link
Collaborator

psavery commented Aug 3, 2023

Could we instead try adding self.materials_panel.update_gui_from_config() to here?

Sure thing.

That needs to be changed to self.materials_panel.update_gui_from_config(). Can you also verify that fixes the issue?

@bnmajor
Copy link
Collaborator Author

bnmajor commented Aug 3, 2023

That needs to be changed to self.materials_panel.update_gui_from_config(). Can you also verify that fixes the issue?

I'm sorry, I read your original comment too fast. This is fixed now and that does work.

@psavery
Copy link
Collaborator

psavery commented Aug 3, 2023

That needs to be changed to self.materials_panel.update_gui_from_config(). Can you also verify that fixes the issue?

I'm sorry, I read your original comment too fast. This is fixed now and that does work.

Great! I think this makes more sense too, since updating the GUI is what we are really doing.

Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnmajor bnmajor merged commit 6cbdb4d into HEXRD:master Aug 3, 2023
9 checks passed
@bnmajor bnmajor deleted the overlay-vis-from-state branch August 3, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlays visible on state load
2 participants