Allow going back a line while hand-picking points #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the user accidentally right-clicked, we would move on to the next line, and there would be no way to go back to the previous line. This would mess up their hand-picking. Now, the "Back" button is enabled, even when the current line has no points, and clicking "Back" when the current line has no points results in going back a line instead. Fixes: #1567 Signed-off-by: Patrick Avery <[email protected]>
Even though the back button was working properly for the Laue points, the canvas did not correctly reflect what was going on. This fixes the issue. Signed-off-by: Patrick Avery <[email protected]>
Previously, only Laue picks on the first detector would be drawn during hand-picking. This was a bug. Now, Laue picks are drawn for all detectors. Signed-off-by: Patrick Avery <[email protected]>
The round-trip of going to cartesian and then back to angles was not working properly if tvec_c was non-zero. This fixes the issue. Signed-off-by: Patrick Avery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the user accidentally right-clicked, we would move on
to the next line, and there would be no way to go back to the previous
line. This would mess up their hand-picking.
Now, the "Back" button is enabled, even when the current line has no
points, and clicking "Back" when the current line has no points results
in going back a line instead.
This PR also adds a couple of extra fixes where Laue spots were not
always being drawn correctly on the canvas while hand-picking
(they were not properly updated when the back button was pressed,
and they were not drawn on the detector after the first one).
Fixes: #1567