Remove tth max options from Fit Grains Options #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These options were actually not doing anything before. The reason is that the user is actually selecting these manually via the "Choose HKLs" button. That also provides the option to filter HKLs by their tth max value. So the tth max options in the Fit Grains Options dialog were not doing anything, and their functionality is already available in the "Choose HKLs" button. Thus, they are removed. Signed-off-by: Patrick Avery <[email protected]>
|
Here is what the dialog used to appear as:
And here are the options that are being removed:
|
Signed-off-by: Patrick Avery <[email protected]>
|
This also adds help buttons to various dialogs in "Fit Grains". See images below.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options were actually not doing anything before. The reason is that the user is actually selecting these manually via the "Choose HKLs" button. That also provides the option to filter HKLs by their tth max value.
So the tth max options in the Fit Grains Options dialog were not doing anything, and their functionality is already available in the "Choose HKLs" button. Thus, they are removed.