changes some plot styles for the polar view #1751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @saransh13! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-24 01:55:10 UTC |
psavery
reviewed
Nov 13, 2024
This makes ticks at Q values of 1, 2, 3, etc. Signed-off-by: Patrick Avery <[email protected]>
saransh13
force-pushed
the
polar-style-changes
branch
from
2e2ddef to
c4e98a5
Compare
Collaborator
|
major and minor ticks using the new class:
|
This might need to be an editable option in the future. Signed-off-by: Patrick Avery <[email protected]>
psavery
reviewed
Nov 24, 2024
hexrdgui/image_canvas.py
Outdated
Comment on lines
1065
to
1068
| self.axis.tick_params( | ||
| bottom=True, top=True, which='major', length=8) | ||
| self.axis.tick_params( | ||
| bottom=True, top=True, which='minor', length=2) |
Collaborator
There was a problem hiding this comment.
I believe these don't have have an effect (these appear to be set by the previous calls to tick_params, and I don't see a difference in the plots if I remove these lines).
Do you know if these lines are necessary?
This way, we can still increase their font sizes if the global font size increases. Signed-off-by: Patrick Avery <[email protected]>
psavery
approved these changes
Nov 24, 2024
Collaborator
psavery
left a comment
psavery
left a comment
There was a problem hiding this comment.
@saransh13 Try out the latest changes. If it looks good to you, then this is ready to be merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example polar view plot below. In the long term, we should make the plot styles editable in the GUI, but for now style this seems a little better to me.