Physics package fixes #1754
Physics package fixes #1754
Conversation
|
Hello @saransh13! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-13 13:42:58 UTC |
hexrdgui/image_canvas.py
Outdated
| # self.axis.xaxis.set_major_locator(PolarXAxisTickLocator(self)) | ||
| # axis.xaxis.set_major_locator(PolarXAxisTickLocator(self)) |
There was a problem hiding this comment.
So, I think we were using these before so that when you set the x-axis to use Q instead, tick markers show up at 1, 2, 3, 4, .... Can you verify that still happens with the above changes? If not, we might need to fix that before merging.
There was a problem hiding this comment.
Yes, looks like switching to Q messes up the xticklabels. We'd have to redo this step when the axis is updated to use Q.
There was a problem hiding this comment.
So actually, those PolarXAxisTickLocator classes inherit AutoLocator. I think that in the code above, where you have yaxis.set_major_locator(AutoLocator()), we might be able to just change that AutoLocator to PolarXAxisTickLocator.
However, we probably also need to change the minor locator, too.
saransh13
force-pushed
the
physics-package-fixes
branch
from
d6c9437 to
90b1b18
Compare
Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
physics-package-fixes
branch
from
90b1b18 to
2f8a662
Compare
psavery
left a comment
psavery
left a comment
There was a problem hiding this comment.
I removed the polar view style changes. If this looks good to you, feel free to merge.
The thicknesses of each layer kept increasing upon repeated selection of pinhole correction. The problem was due too using a dictionary by reference. Fixed by making a copy and editing it instead of original dictionary.