Repeat "hdiutil create" commands to avoid failures #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psavery
force-pushed
the
fix-hdiutil-spurious-failures
branch
from
0a072b1 to
2b079f3
Compare
Race conditions with XProtect on macos-13 can cause spurious failures for `hdiutil create` commands. As a work-around, try the `hdiutil create` command several times (up to 10), and only fail if the command fails each time. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
fix-hdiutil-spurious-failures
branch
from
2b079f3 to
0d9baee
Compare
jurzik
added a commit
to vanillapdf/vanillapdf
that referenced
this pull request
Sep 29, 2025
- Add scripts/hdiutil_retry.sh to work around XProtect race conditions - Configure CPack to use retry script on macOS (CPACK_COMMAND_HDIUTIL) - Script retries hdiutil create up to 10 times with 1-second delays - Based on workaround from HEXRD project: HEXRD/hexrdgui#1768 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Merged
3 tasks
jurzik
added a commit
to vanillapdf/vanillapdf
that referenced
this pull request
Oct 4, 2025
…146) * fix: Add hdiutil retry script to resolve macOS CPack build failures - Add scripts/hdiutil_retry.sh to work around XProtect race conditions - Configure CPack to use retry script on macOS (CPACK_COMMAND_HDIUTIL) - Script retries hdiutil create up to 10 times with 1-second delays - Based on workaround from HEXRD project: HEXRD/hexrdgui#1768 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * fix: Ensure hdiutil_retry.sh has execute permissions - Mark scripts/hdiutil_retry.sh as executable in Git index - Fixes "permission denied" error when CPack tries to execute the script - Resolves macOS DMG creation failures in GitHub Actions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * fix: Improve hdiutil retry script for macOS XProtect race conditions - Use full path to hdiutil (/usr/bin/hdiutil) to avoid PATH issues - Increase retry delay from 1s to 2s to give XProtect more time - Redirect error messages to stderr for better logging - Add reference to CMake issue #25671 - Improve error messages to show which hdiutil command failed Related: https://gitlab.kitware.com/cmake/cmake/-/issues/25671 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race conditions with XProtect on macos-13 can cause spurious failures
for
hdiutil createcommands.As a work-around, try the
hdiutil createcommand several times (upto 10), and only fail if the command fails each time.