Mask manager dialog

[bnmajor]

• Remove the "remove mask" column in favor of the "remove selected" option
• Remove the presentation combo boxes for each mask. Instead, list the current presentation status as text as use global presentation selection drop-down for selected masks
• Remove the "apply changes" button since all updates are now immediate
• Highlight masks as they are selected
• Add options to set highlight color and opacity in the style dialog

Relies on #1849

[saransh13]

Two issue I found:

1. cannot change mask appearance for single selection.
2. The presentation field is editable.

The polygon filling of the mask feels a little laggy currently. It'd be a great improvement if we can improve that aspect as well.

[bnmajor]

Remaining issues:

• highlighting remains if dialog is closed

[saransh13]

LGTM. Will wait for Patrick to have the final approval before merge.

[psavery]

Looks like there's a merge conflict. @bnmajor can you resolve that?

I'm going to take a look over the code now...

[psavery]

This means that highlighted masks will affect the azimuthal lineout, even if the masks are not "visible" or the border is not shown. I think that's probably not what we want. We probably want to keep it the way it was before (only affect the azimuthal lineout if the mask is visible or the border is shown).

[psavery]

So I'd recommend just removing this change.

[psavery]

Suggested change

	highlight=False
	highlight=False,

I'd recommend including a , at the end of all final arguments. The reason is that, without it, a new change is necessary in the changelog to add a comma to the previous one (as is the case here for xray_source=None). This can cause confusion as to who authored that line and why it was authored.

[psavery]

I think we need a new signal/slot mechanism that, when the user's selection changes, it only triggers highlight artist updates (and doesn't retrigger all the polar mask logic).

[psavery]

This would make highlight selections much faster.

[psavery]

So, the purpose of using the blit manager (and the animation features) is to avoid calling self.draw() and self.draw_idle(), because those can be expensive calls when you need faster speeds for things like animations. Instead, self.blit_manager.update() is all you need.

And, it looks like the highlight_masks() function already calls self.blit_manager.update(), so you can safely remove both calls to self.draw_idle() above.

After you remove these, you might also no longer need the debouncer in the mask manager dialog, because the updates should be much faster. But I'll leave it up to you whether to keep the debouncer or not.

[psavery]

By the way, the calls to self.draw_idle() are most time-consuming when the polar view has a very high resolution (small tth and eta pixel size). So you may not notice the performance impact much unless you switch to higher resolutions.

However, our users do typically work with high resolution polar views.

[psavery]

LGTM