Implement fixes for LLNL workflows #1909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intensity corrections cause problems during LLNL import. The FIDDLE image plate, for example, doesn't work at all. Just disable all intensity corrections during the LLNL import, and the user can manually re-enable them afterward. Signed-off-by: Patrick Avery <[email protected]>
Oftentimes, when a powder ring is highlighted, the powder range would be highlighted incorrectly (typically a range on a different ring to the left of the highlighted ring). This was due to the fact that `rbnd_indices` are indices into the two theta list, and not into the ring array. We added a ring map to fix this, and now the correct range is always highlighted. Signed-off-by: Patrick Avery <[email protected]>
This fixes an issue where, when you switch to tabbed view and a bunch of canvases get allocated, a whole bunch of toolbars also appear. Now, only the correct toolbar will appear. Signed-off-by: Patrick Avery <[email protected]>
They both use blitting, and unfortunately the zoom canvas does not utilize the canvas's blit manager (which it should). Because of that, when a blit update is being performed by both the main canvas and the zoom canvas, there is some bouncing back and forth in the rendering. This mainly manifests itself by the highlighted line bouncing around. This commit fixes the issue. Signed-off-by: Patrick Avery <[email protected]>
We previously would not consider the tth distortion when saving picks, so the cartesian coordinates would be incorrect. Now we reverse the tth distortion if needed. Also, the two calibration workflows (Composite and Fast Powder) write the coordinates directly from the overlays, which is more accurate (some precision is lost when converting back and forth between cartesian and polar when the tth distortion is applied, because it is a field correction). Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
fiddle-updates
branch
from
6d913f0 to
c48b962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few small issues with LLNL workflows, including:
Fixes: #1864
Fixes: #1905