Do not allow memoized median output to be modified #1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a copy of the memoized median filter output so that we can be sure the array will not be modified. This was causing a bug where, if you had one state file loaded in with the median filter applied, and you load in another state file that has the median filter applied, the memoized output was somehow modified and made the image data invalid. Making a copy of the memoized output ensures that it won't be modified. Signed-off-by: Patrick Avery <[email protected]>
saransh13
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a copy of the memoized median filter output so that we can be sure the array will not be modified.
This was causing a bug where, if you had one state file loaded in with the median filter applied, and you load in another state file that has the median filter applied, the memoized output was somehow modified and made the image data invalid.
Making a copy of the memoized output ensures that it won't be modified.
To ensure this problem does not happen again, HEXRD/hexrd#837 was also created.