Invalidate polar masks on detector transform #1911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The polar masks need to be regenerated when the detectors are transformed. This adds functionality that does so. Signed-off-by: Patrick Avery <[email protected]>
psavery
commented
Sep 4, 2025
| def invalidate_detector_masks(self, det_keys: list[str]): | ||
| for mask in self.masks.values(): | ||
| if any(v[0] in det_keys for v in mask.data): | ||
| mask.invalidate_masked_arrays() |
Collaborator
Author
There was a problem hiding this comment.
@bnmajor can you verify this function looks good?
Collaborator
There was a problem hiding this comment.
Awesome, looks great to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polar masks need to be regenerated when the detectors are transformed. This adds functionality that does so.