Skip to content

Move blit manager update out of mask highlights #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

Move blit manager update out of mask highlights #1915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions hexrdgui/image_canvas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,10 +1559,12 @@ def mask_highlights_changed(self):
self.clear_mask_highlights()
for det_name, ax in self.raw_axes.items():
self.highlight_masks(ax, det_name)
self.blit_manager.update()
return

if self.mode in (ViewType.polar, ViewType.stereo):
self.update_mask_highlights(self.axis)
self.blit_manager.update()

def polar_masks_changed(self):
skip = (
Expand Down Expand Up @@ -2280,9 +2282,10 @@ def draw_mask_boundaries(self, axis, det=None):
)

def highlight_masks(self, axis, det=None):
# Don't update the blit manager here, so we can better control
# it elsewhere
all_verts = self.get_mask_verts('highlights', det)
if not all_verts:
self.blit_manager.update()
return

kwargs = {
Expand All @@ -2300,8 +2303,6 @@ def highlight_masks(self, axis, det=None):
axis.add_patch(polygon)
highlight_artists.append(polygon)

self.blit_manager.update()

def remove_all_mask_highlight_artists(self):
self.blit_manager.remove_artists('mask_highlights')
self.blit_manager.artists['mask_highlights'] = {}
Expand Down
Loading