Change mask presentation selector when masks are selected #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brianna Major <[email protected]>
psavery
reviewed
Sep 24, 2025
Collaborator
psavery
left a comment
psavery
left a comment
There was a problem hiding this comment.
This is fine with me if it works how Saransh wants it to!
saransh13
approved these changes
Sep 29, 2025
Member
saransh13
left a comment
saransh13
left a comment
There was a problem hiding this comment.
This option works well in most cases. When all masks are all None or Visible. Maybe a future improvement would to to deal with cases when there is mixed parity between the selections (some None and some Visible). This is a minor improvement though and can be done in the future. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch addresses an issue raised by @saransh13: When masks are selected the presentation selector does not change, so if you want to set them all to
Noneyou would have to change it toVisiblethen back toNone.When a masks are selected we now try to change the presentation selector to best match the selected masks.