Skip to content

pass sample rotation matrix instead of sample normal #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2025
Merged

pass sample rotation matrix instead of sample normal #1920

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fab0e95
pass sample rotation matrix instead of sample normal
saransh13 Oct 6, 2025
17a96cc
filter cases when LeBail class is used, which can not have a texture …
saransh13 Oct 13, 2025
0935977
Minor cleanup
psavery Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion hexrdgui/calibration/wppf_options_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2024,6 +2024,9 @@ def _copy_texture_figs(self, obj1, obj2):
if obj1 is None or obj2 is None:
return

if any(not hasattr(x, 'texture_model') for x in (obj1, obj2)):
return

for model_key, model1 in obj1.texture_model.items():
model2 = obj2.texture_model[model_key]
if model1 is None or model2 is None:
Expand Down Expand Up @@ -2242,7 +2245,7 @@ def texture_model_dict(self) -> dict[str, HarmonicModel]:
'material': Material_Rietveld(material_obj=mat),
'bvec': HexrdConfig().beam_vector,
'evec': ct.eta_vec,
'sample_normal': HexrdConfig().sample_normal,
'sample_rmat': HexrdConfig().sample_rmat,
**kwargs,
})
return ret
Expand Down
Loading