Set pinhole thickness to zero when disabled #1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the thickness of any layer is properly set to zero when they are disabled - including the pinhole. Layers having a thickness of zero is what indicates that they don't exist. This is properly handled in the absorption correction math. Fixes: #1922 Signed-off-by: Patrick Avery <[email protected]>
This old API was removed. I don't see any valid replacements. Just try calling the conda commands directly. Signed-off-by: Patrick Avery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the thickness of any layer is properly set to zero when they are disabled - including the pinhole.
Layers having a thickness of zero is what indicates that they don't exist. This is properly handled in the absorption correction math.
Fixes: #1922