Wrap poc select in error component, event summary on training report #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewatermethod
requested review from
nvms,
hardwarehuman,
GarrettEHill,
kryswisnaskas and
AdamAdHocTeam
nvms
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Turned up this during accessibility review. An earlier change fixed the validation on blur but it turns out this component wasn't wrapped in the correct code to actually display an error.
How to test
You'll need to be an admin.
Blur the poc select field, selecting nothing, and confirm that the error message appears.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy