Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] We need to ensure we are only opening and closing goals that are createdVia monitoring #2711

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AdamAdHocTeam
Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam commented Mar 11, 2025

Description of change

We had an issue running the createMonitoringGoals job today. After further investigation it turned out that we were attempting to close a deleted goal. This modifies the job to only open and close goals created via 'monitoring'.

How to test

  • Review the code.
  • Pull the latest backup from KB and run the job.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete
  • QA review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@AdamAdHocTeam AdamAdHocTeam marked this pull request as ready for review March 11, 2025 20:49
Copy link
Collaborator

@kryswisnaskas kryswisnaskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tommaroh
Copy link
Collaborator

tommaroh commented Mar 11, 2025

What was the error that was logged in this case? Was it sufficient to quickly identify the root cause or is there anything we could add to make it easier in the future for similar types of problems?

@AdamAdHocTeam
Copy link
Collaborator Author

What was the error that was logged in this case? Was it sufficient to quickly identify the root cause or is there anything we could add to make it easier in the future for similar types of problems?

@tommaroh this is a good point and the thought crossed my mind. Although at the time my primary focus was getting the job to pass on production. I have added some logging that will give us the error and the call stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants