Update schema to require funding field on /can-funding-recieved #3337
Merged
Update schema to require funding field on /can-funding-recieved #3337
funding field on /can-funding-recieved #3337Conversation
maiyerlee
changed the title
funding field on /can-funding-recieved
maiyerlee
requested review from
Santi-3rd,
fpigeonjr,
johndeange,
rajohnson90 and
weimiao67
weimiao67
approved these changes
Jan 27, 2025
fpigeonjr
approved these changes
Jan 27, 2025
Contributor
fpigeonjr
left a comment
fpigeonjr
left a comment
There was a problem hiding this comment.
🤔 is there any impact to our our types in the CANTypes.d.ts
Contributor
Author
I don't think so. The response will stay the same. I double-checked where we make the FE call and we're always setting a funding value. |
johndeange
approved these changes
Jan 27, 2025
maiyerlee
deleted the
OPS-310/3209_budget_is_required_on_can_funding_recieved
branch
|
🎉 This PR is included in version 1.32.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
maiyerlee
added a commit
that referenced
this pull request
Jan 27, 2025
…ed (#3337) * feat: make funding required on create and update CAN funding received * test: rename test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This will require the funding field on the /can-funding-recieved endpoint, as specified in the marshmallow schema.
Issue
3209
How to test
Test passing.
Screenshots
N/A
Definition of Done Checklist
Links
N/A