Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops 3343/funding partner #3344

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Ops 3343/funding partner #3344

wants to merge 6 commits into from
+213 −116

Conversation

johndeange
Copy link
Contributor

@johndeange johndeange commented Jan 22, 2025 •
edited
Loading

What changed

  • Load FUNDING_PARTNER for CANFundingDetails
  • Fix duplicate DG Portfolio

Issue

#3343

How to test

Automated tests pass.

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpigeonjr fpigeonjr fpigeonjr approved these changes

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

@weimiao67 weimiao67 Awaiting requested review from weimiao67

At least 3 approving reviews are required to merge this pull request.

Assignees

@johndeange johndeange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johndeange @rajohnson90 @fpigeonjr