Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding needed permissions to the viewer/editor role to meet the criteria #3346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding needed permissions to the viewer/editor role to meet the criteria #3346

wants to merge 1 commit into from

Conversation

jonnalley
Copy link
Contributor

@jonnalley jonnalley commented Jan 23, 2025 •
edited
Loading

What changed

  • Adds necessary permissions to the Viewer/Editor as well as System Owner roles such that both roles can create SCs and BLs on new or existing contracts they're authorized to be adding content like that to.

Issue

#3338

How to test

Repeat the same steps from the issue above

Screenshots

Definition of Done Checklist

~ [ ] OESA: Code refactored for clarity~
- [ ] OESA: Dependency rules followed

  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
    - [ ] Form validations updated

Links

User roles

@jonnalley jonnalley linked an issue Jan 23, 2025 that may be closed by this pull request
Viewer/Editor role can't create SCs or BLs #3338
Open
@jonnalley jonnalley marked this pull request as ready for review January 23, 2025 07:09
@jonnalley jonnalley self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@johndeange johndeange johndeange approved these changes

@fpigeonjr fpigeonjr Awaiting requested review from fpigeonjr

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

@weimiao67 weimiao67 Awaiting requested review from weimiao67

At least 3 approving reviews are required to merge this pull request.

Assignees

@jonnalley jonnalley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Viewer/Editor role can't create SCs or BLs
3 participants
@jonnalley @johndeange @rajohnson90