[Issue #422] Fix script for generating release notes#424
Merged
Conversation
The old script used the wrong query param to pass the config file to the generate release notes API `configuration_file` instead of `configuration_file_path`
jcrichlake
approved these changes
Nov 19, 2025
Collaborator
Author
|
Follow up note on closing this out: I deleted the temporary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the generate release notes script. The old script used the wrong query param to pass the config file to the generate release notes API (
configuration_fileinstead ofconfiguration_file_path)Changes proposed
validate-and-generate-release-notes.shContext for reviewers
To validate this I created a temporary
[email protected]tag since the generate release notes API endpoint only works if the tag you pass is tied to a commit after the config files were added to themainbranch of the repo.Once we merge this in I'll delete that tag.
Additional information
Here's the dry-run with the temporary v0.3.3 tag
Here's the comparison of all commits between the two tags, showing that we're filtering out non-relevant PRs.
Note
I've since deleted the temporary tag we created to validate this behavior.