Skip to content

Feat: fix deleted by doc id #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FeHuynhVI
Copy link
Contributor

Description
Fix issue related to document deletion logic. The bug previously prevented proper removal of items from the FAISS vector store.

Related Issues
N/A

Changes Made
Fixed the delete function to ensure correct removal from FAISS.

Verified that deletion works as expected locally.

Checklist
Changes tested locally

Code reviewed

Documentation updated (if necessary)

Unit tests added (if applicable)

Additional Notes
The issue was isolated to FAISS indexing during document deletion. After applying the fix, local tests confirmed the functionality works correctly.

@FeHuynhVI
Copy link
Contributor Author

FeHuynhVI commented May 9, 2025

It seems that a hallucination occurred after the delete operation. If anyone has any ideas, please feel free to comment and help

"I'm using FAISS as the vector database, with all data stored locally."

@danielaskdd
Copy link
Collaborator

LightRAG relies significantly on entity and relation summaries to generate accurate responses to queries; therefore, removing vector chunks can lead to hallucinations.

@FeHuynhVI
Copy link
Contributor Author

LightRAG relies significantly on entity and relation summaries to generate accurate responses to queries; therefore, removing vector chunks can lead to hallucinations.

"In a real-world project, not being able to delete or update documents makes things extremely difficult. I might need to consider replacing the current solution.

@danielaskdd
Copy link
Collaborator

If we retain all original entity and relation descriptions along with the corresponding document IDs from which these descriptions originate, we will be able to re-aggregate the descriptions after a specific document ID has been deleted.

This feature is currently on the LightRAG roadmap. Any discussion or contributions regarding this feature are welcome.

@zcfrank1st
Copy link

any update?

@FeHuynhVI
Copy link
Contributor Author

any update?

I’ve switched to RAGFlow, but I don’t have enough experience to handle this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants