-
-
Notifications
You must be signed in to change notification settings - Fork 203
Accessibility content 2025 #4298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility content 2025 #4298
Conversation
Adds the final markdown file together with the generated images (ran through tinypng)
tunetheweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chapter looks good so far but have some image feedback. Will review rest later.
|
@tunetheweb Thanks for all this! I fixed all of them and a few more. |
|
Let me know if I missed anything. Thanks again! |
tunetheweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good read!
I think this is almost ready to merge. I did a thorough review and picked up so improvements, nits, and formatting but most are small overall.
Could you look at the chart positioning across the chapter? As only spotted that halfway thought but then noticed it more and more.
Almost done now!
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
Add AI intro text, improve some figure descriptions.
|
@tunetheweb thanks for reviewing everything. I think I went through everything now. There was a persistent problem with that vertical axis showing "Percent of input element" - it's present on A LOT of charts even in 2024! :) I changed everything in 2025 though. Would you mind giving it another look? |
tunetheweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few final tweaks
|
OK I think this is good to merge. @tricinel let me know if you're happy to merge or are waiting on any other reviews from any of the chapter team. |
- Changed email to newsletter in Bogdan's bio - Changed chapter to section in the AI intro
|
All good then. We're not waiting on any other reviews, no. Just made a small tweak to my bio. And changed "chapter" to "section" in that AI intro. Thanks for taking the time to review this chapter and all the help along the way! |
|
Thank you for all your hard work. Feel free to send follow up PRs if you spot any typos or things you wanna change. |
Closes #4063
We now have the final Accessibility content for 2025, including the tinypng-compressed images. I am only missing the DOI number.
Staged version: