Skip to content

Performance insight audits #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 9, 2025
Merged

Performance insight audits #114

merged 13 commits into from
Jun 9, 2025

Conversation

max-ostapenko
Copy link
Contributor

@max-ostapenko max-ostapenko commented Jun 9, 2025

  • Some reformatting without affecting the logic

@max-ostapenko max-ostapenko requested a review from tunetheweb June 9, 2025 10:50
@tunetheweb
Copy link
Member

Interesting idea.

As it's sometimes a many-one mapping from new to old, will this lead to duplication?

Also, because of that, it's not true to see they are continuations of the old audits. In some cases they are (though tweaked), in other cases they are a combination of several audits.

Since we never exposed the individual lighthouse audits before in the CWV Tech Report (well we did a few, but not many and none of these) I'm wonder if we need the mapping and shouldn't just start the insights from the time we start to gather them as if they were completely new audits?

@max-ostapenko
Copy link
Contributor Author

As it's sometimes a many-one mapping from new to old, will this lead to duplication?

No. We group by name and category (category is performance and names will collapse).
It may be an optimistic PassRate though, as we'll save a pass when at least one passed.

Also, because of that, it's not true to see they are continuations of the old audits. In some cases they are (though tweaked), in other cases they are a combination of several audits.

Since we never exposed the individual lighthouse audits before in the CWV Tech Report (well we did a few, but not many and none of these) I'm wonder if we need the mapping and shouldn't just start the insights from the time we start to gather them as if they were completely new audits?

@tunetheweb So let's skip all the old ones? Data starts from May 2025 CrUX then?

@tunetheweb
Copy link
Member

@tunetheweb So let's skip all the old ones? Data starts from May 2025 CrUX then?

Will we get the longer history for audits that didn't change? Or are we starting everything from May 2025?

@max-ostapenko
Copy link
Contributor Author

max-ostapenko commented Jun 9, 2025

My idea was to reprocess the data for version breakdowns (form 2020-01) once we have an idea for a new DB setup.

How far would you want to go? The earliest I've seen is somewhere in 2017.

@tunetheweb
Copy link
Member

Yeah looks like we started running Lighthouse from June 2017. Sure let's go all the way back.

In which case it might be useful to keep the old metrics and just let them die out when we remove them from Lighthouse? That would also give us an overlap of the old and new if anyone ever wanted to compare them.

@max-ostapenko
Copy link
Contributor Author

Ok, removed the mapping.
Let's collect all of them.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-ostapenko max-ostapenko merged commit a724c2c into main Jun 9, 2025
28 checks passed
@max-ostapenko max-ostapenko deleted the visible-gecko branch June 9, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants