Use custom multi select dropdowns for the tech selector #1043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
from meeting:
|
tunetheweb
reviewed
Apr 30, 2025
tunetheweb
requested changes
May 14, 2025
| option.id = `${this.element.dataset.id}-${row}`; | ||
| const logo = document.createElement('img'); | ||
| logo.setAttribute('alt', ''); | ||
| logo.setAttribute('src', `https://cdn.httparchive.org/static/icons/${row}.png`); |
There was a problem hiding this comment.
This assumes the icon is the technology name, but that's not always the case.
For example:
- "Yandex SmartCaptcha" - "yandex_smartcaptcha.png"
It also doesn't work when a technology reuses an icon. For example:
"Yandex.Cloud": {
"cats": [
62
],
"description": "Yandex.Cloud is a public cloud platform where companies can create and develop projects using Yandex's scalable computing power, advanced technologies, and infrastructure.",
"icon": "Yandex.Cloud.svg",
"pricing": [
"payg"
],
"saas": false,
"website": "https://cloud.yandex.com/en/"
},
"Yandex.Cloud CDN": {
"cats": [
31
],
"description": "Yandex.Cloud CDN helps you streamline static content delivery for your web service.",
"dom": "[href*='storage.yandexcloud.net'], [src*='storage.yandexcloud.net']",
"icon": "Yandex.Cloud.svg",
"implies": "Yandex.Cloud",
"website": "https://cloud.yandex.com/en/services/cdn"
},
Can we pull in the actual icon name from the API?
There was a problem hiding this comment.
Yes, but then we need to drop the ?onlyname from the request to the technologies endpoint, and we added it a while back to speed up the API response 😅
So options are:
- Fetch the icons for the dropdowns using
/v1/technologies, have a slower API response - Keep the icons in the dropdowns based on the names (
/v1/technologies?onlyname), have some icons not show up - Remove the icon from the dropdowns
@max-ostapenko it seems that your open PR #1048 will speed up the technologies endpoint, do you think it will be ok to use it again without the onlyname for the dropdowns?
Co-authored-by: Barry Pollard <[email protected]>
Co-authored-by: Barry Pollard <[email protected]>
…nto cwvtech-dropdown
tunetheweb
approved these changes
Jun 2, 2025
tunetheweb
reviewed
Jun 2, 2025
This was referenced Jun 2, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Related to
Screenshots
Input field, collapsed
Input field, open, nothing searched
Searching for a tech
Tech selected
Multiple tech selected
Multiple tech selected, not filtered
10 techs selected, unable to pick more