[pull] dev-2.x from oldratlee:dev-2.x #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
… instead of `&&-||` NOTE: - the `echo` option(e.g. -e -n) may effect correctness, `printf` is more robust 💪 - about `&&-||` see shell check: https://www.shellcheck.net/wiki/SC2015
…cho` option(e.g. -e -n) may effect correctness 🐞 , `printf` is more robust 💪
… the index number
…e `if-else` instead of `&&-||` NOTE: - the `echo` option(e.g. -e -n) may effect correctness, `printf` is more robust 💪 - about `&&-||` see shell check: https://www.shellcheck.net/wiki/SC2015
…flect as exit code; improve portability(`portableRelPath/portableReadLink`) NOTE: - use `printf` 💪 instead of `echo`; use `if-else` instead of `&&-||` - the `echo` option(e.g. -e -n) may effect correctness, `printf` is more robust 💪 - about `&&-||` see shell check: https://www.shellcheck.net/wiki/SC2015
…reflect as exit code; improve portability(`portableRelPath/portableReadLink`) NOTE: - use `printf` 💪 instead of `echo`; use `if-else` instead of `&&-||` - the `echo` option(e.g. -e -n) may effect correctness, `printf` is more robust 💪 - about `&&-||` see shell check: https://www.shellcheck.net/wiki/SC2015
…o`; use `if-else` instead of `&&-||`; improve portability(`portableReadLink`) NOTE: - the `echo` option(e.g. -e -n) may effect correctness, `printf` is more robust 💪 - about `&&-||` see shell check: https://www.shellcheck.net/wiki/SC2015
…es.sh`): use `printf` 💪 instead of `echo`; use `if-else` instead of `&&-||` NOTE: - the `echo` option(e.g. -e -n) may effect correctness, `printf` is more robust 💪 - about `&&-||` see shell check: https://www.shellcheck.net/wiki/SC2015
…` instead of `&&-||`; use `${var#}` instead of `awk`
NOTE:
- the `echo` option(e.g. -e -n) may effect correctness, `printf` is more robust 💪
- about `&&-||` see shell check:
https://www.shellcheck.net/wiki/SC2015
…`echo`; use `if-else` instead of `&&-||` NOTE: - the `echo` option(e.g. -e -n) may effect correctness, `printf` is more robust 💪 - about `&&-||` see shell check: https://www.shellcheck.net/wiki/SC2015
- use `printf` 💪 instead of `echo`
- the `echo` option(e.g. -e -n) may effect correctness, `printf` is more robust 💪
- use `if-else` instead of `&&-||`
- about `&&-||` see shell check:
https://www.shellcheck.net/wiki/SC2015
- small improvement/refactor
oldratlee
force-pushed
the
dev-2.x
branch
6 times, most recently
from
6a7832d to
94a89c6
Compare
oldratlee
force-pushed
the
dev-2.x
branch
7 times, most recently
from
02f6a2e to
80d5041
Compare
oldratlee
force-pushed
the
dev-2.x
branch
3 times, most recently
from
e449dc9 to
47f1e94
Compare
oldratlee
force-pushed
the
dev-2.x
branch
3 times, most recently
from
e8a354c to
fd420c9
Compare
oldratlee
force-pushed
the
dev-2.x
branch
8 times, most recently
from
9cc5680 to
934e57e
Compare
- keep `usage` function simple - use `-s`/`-h` option for optional argument of `die` function - use bash builtin `type -P` instead of `which` command 🐚 - rename var, use `COLOR_INDEX` instead of `COUNT`
file paths may contain leading spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )