postpone consumePurchase until after server-side purchases credit #2155
+18
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In PurchaseHandler.handleError, remove automatic consumePurchase on any error to avoid burning tokens before gems arrive. - Only call consumePurchase() after the backend confirms gems have been credited. - Add retry logic around startListening/queryPurchases so any unconsumed purchases are picked up when the app launches. - Prevent lost purchases by ensuring the client only consumes tokens once we know the user got their gems. (This change works in tandem with the backend fix that defers marking receipts consumed until after successful gem credit.)
Hafizzle
requested review from
phillipthelen,
saraolson and
SabreCat
and removed request for
SabreCat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This change works in tandem with the backend fix that defers marking receipts consumed until after successful gem credit.)