-
Notifications
You must be signed in to change notification settings - Fork 5
add wasmJs target #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Piasy hi |
Hi @GGsrvg , thank you for your contribution. Actually I'm very curious how would you implement the actual log logic in wasm? I did some research earlier, but I didn't find any good ways to implement similar things as tencent's mars xlog, so I choose simple console log for js platform. |
@Piasy
|
I mean in Any way, if you don't plan to open source your implementation, this PR shouldn't be merged, and you can create and use your own fork. |
@Piasy I don't have my own implementation, this file is only needed to say that the implementation from the common module (which you write |
I wrote "private implementation" because in |
kmp-xlog/build.gradle.kts
Outdated
@@ -79,109 +85,111 @@ kotlin { | |||
} | |||
} | |||
|
|||
mingwX64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please revert changes below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't remove mingw, I just wrapped it in a Windows check
if (OperatingSystem.current().isWindows)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to add such check, if you open the project or build the project on Linux/macOS, windows target will be disabled automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... last time the check on windows allowed to success build the project
check is a removed
/** | ||
* Created by GGsrvg{github.com/GGsrvg} on 2025/12/30. | ||
*/ | ||
// using a private implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file isn't necessary, please delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready
v1.3.1 is released. |
I added support wasm js target