This repository was archived by the owner on Mar 29, 2022. It is now read-only.
Introduce I18n to Hacktoberfest#675
Open
ChaelCodes wants to merge 4 commits intoHacktoberfest:masterfrom
Open
Conversation
…lso, error if there are missing key in development
Contributor
|
Gonna label this as accepted so that it counts, just in case we don't get around to reviewing it in time. Tyvm for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
starts #444
One of the decisions I made was to pass locale via params - and to include the current locale in the default URL params. This could potentially set up a user expectation that they could modify the locale and see a translated version of the page, which is not fully implemented. I wonder if it'd be better to add that change once the site has been fully internationalized, and a few translations added.
Test process
/?locale=enis added to the URL?locale=enstays on the URL?locale=esRequirements to merge