Skip to content

Replace PNG sponsor assets with SVGs #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Siddharthgup
Copy link

@Siddharthgup Siddharthgup commented Oct 6, 2024

What should this PR do?

  1. Replace PNG sponsor assets with their SVG equivalents across the project.
  2. Update all references to sponsor logos from .png to .svg in HTML, CSS, and other code files.
  3. Ensure the SVG files improve scalability, performance, and responsiveness on various devices.

What issue does this relate to?

Resolves #70

What are the acceptance criteria?

  1. All PNG sponsor logos have been replaced with SVG equivalents.
  2. Ensure the SVG files render properly on all major browsers (Chrome, Firefox, Safari, Edge).
  3. Verify that the page's responsiveness is not affected by the new SVG logos.

Copy link
Contributor

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Where did you source the SVGs from used in here? They seem very low quality, like some tracing software has been used from the PNGs, rather than finding actual SVGs published by the brands?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the change to this file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the change to this file

@MattIPv4 MattIPv4 changed the title Replace png files with svg files #70 Replace PNG sponsor assets with SVGs Oct 6, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the formatting changes on this file, all files should be formatted by prettier

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, are you referring to the VS code extension?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a VSCode extension for prettier, but you don't need to use it, prettier is a dependency in this repository. npm ci && npm run format.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to be a PNG inside an SVG, can we get an actual SVG from Holopin for it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holopin appears to be a paid platform for badges, I'm not sure how that could be used here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the logo for Holopin, so can we get an SVG version from them?

@MattIPv4
Copy link
Contributor

MattIPv4 commented Oct 9, 2024

👋 @Siddharthgup any update on this?

@kingsmen732
Copy link

is this issue still open or does it need to closed? @MattIPv4
kindly assign me if its still open :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace PNG sponsor assets with SVGs
3 participants