-
Notifications
You must be signed in to change notification settings - Fork 16
Replace PNG sponsor assets with SVGs #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Where did you source the SVGs from used in here? They seem very low quality, like some tracing software has been used from the PNGs, rather than finding actual SVGs published by the brands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the change to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the change to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the formatting changes on this file, all files should be formatted by prettier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, are you referring to the VS code extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a VSCode extension for prettier, but you don't need to use it, prettier is a dependency in this repository. npm ci && npm run format
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file seems to be a PNG inside an SVG, can we get an actual SVG from Holopin for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holopin appears to be a paid platform for badges, I'm not sure how that could be used here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the logo for Holopin, so can we get an SVG version from them?
👋 @Siddharthgup any update on this? |
is this issue still open or does it need to closed? @MattIPv4 |
What should this PR do?
What issue does this relate to?
Resolves #70
What are the acceptance criteria?