Skip to content

Commit

Permalink
Introduce workaround for bug in controlsfx
Browse files Browse the repository at this point in the history
  • Loading branch information
Hanseter committed Sep 18, 2024
1 parent 9ef979c commit 879f1ac
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
19 changes: 7 additions & 12 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.github.hanseter</groupId>
<artifactId>json-properties-fx</artifactId>
<version>2.0.0</version>
<version>1.0.17</version>

<packaging>bundle</packaging>
<name>JSON Properties Editor Fx</name>
Expand Down Expand Up @@ -35,12 +35,12 @@


<properties>
<maven.compiler.source>21</maven.compiler.source>
<maven.compiler.target>21</maven.compiler.target>
<kotlin.compiler.jvmTarget>21</kotlin.compiler.jvmTarget>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<kotlin.compiler.jvmTarget>17</kotlin.compiler.jvmTarget>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<kotlin.version>2.0.10</kotlin.version>
<javafx.version>21.0.4</javafx.version>
<kotlin.version>1.9.20</kotlin.version>
<javafx.version>17.0.12</javafx.version>
<slf4j.version>1.7.32</slf4j.version>
</properties>

Expand Down Expand Up @@ -192,12 +192,7 @@
<version>${slf4j.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.testfx</groupId>
<artifactId>openjfx-monocle</artifactId>
<version>21.0.2</version>
<scope>test</scope>
</dependency>

</dependencies>

</project>
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ class EnumSetControl(
while (c.next()) {
//mill changes
}
//checkbox model is buggy when there are two selected elements and the first one was deselected.
//even though this looks like a nop, it forces the checkbox model to "reload"
//should be this bug in controlsfx: https://github.com/controlsfx/controlsfx/issues/1550
c.list.forEach { }
controlChanged(c.list)
}

Expand Down

0 comments on commit 879f1ac

Please sign in to comment.